igorkasyanchuk/active_storage_validations

[Validator] Add new aspects ratios like `aX`

Open

#375 opened on Apr 18, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Ruby (148 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (1,179 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

AX (a1, a2, ...) ratio are approximatively 1:1.4142.

Would be a great idea to have some new aspect_ratios, like:

  • AX, AX_portrait, AX_landscape

AX being AX_portrait and AX_landscape allowed.

Since all AX share the same aspect ratio, we should recognise the AX / AX_landscape / AX_portait pattern, and validate accordingly.

Contributor guide

Research direction
Examine the current aspect ratio validator implementation, specifically how existing ratios like 'landscape' or 'portrait' are recognized, and extend it to handle the AX, AX landscape, AX portrait pattern by matching against a common aspect ratio value (approx 1:1.4142).
Tech stack
ruby
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyRuby on Railsaspect ratio knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70