igorkasyanchuk/active_storage_validations

Validations not working on Ckeditor gem models?

Closed

#145 opened on Feb 24, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Ruby (148 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (1,179 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello! I am unsure if this should mentioned here or under the ckeditor gem...

I have noticed that adding validations for file content types and sizes for Ckeditor::Picture, Ckeditor::Asset, and Ckeditor::AttachmentFile models do not seem to work.

Adding: validates :storage_data, size: { less_than: 5.megabytes }, content_type: /\Aimage\/.*\z/ or validates :storage_data, size: { less_than: 5.megabytes }, content_type: ['image/png', 'image/jpg', 'image/jpeg'] in any of the above listed models do not restrict a large image or a pdf from being uploaded. The types seem to be registered with Marcel::EXTENSIONS

ckeditor gem (5.1.1) active_storage_validations gem (0.9.6)

Contributor guide

Research direction
Inspect how validations are applied to Ckeditor models and check if the 'storage data' attribute is an ActiveStorage::Attached::One or similar. Verify if the 'active storage validations' gem supports validations on nested models or if there's a missing inclusion of the validator module.
Tech stack
ruby
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyRails
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75