idyll-lang/idyll

React lifecycle warning

Open

#711 opened on Mar 10, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,977 stars) (97 forks)batch import
ComponentsGood First PRRough EdgesRuntimehelp wanted

Description

Describe the bug Some components depend on React lifecycle methods that are being deprecated, see this warning:

Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.\n

To Reproduce Create the default idyll article and look at terminal and JS console.

Expected behavior There are no warnings from React. I believe the idyll-document component relies on this method, as well as several components in idyll-components, including at least table, maybe others.

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with ReactNode.js installed
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The error involves deprecated lifecycle methods in React, particularly componentWillReceiveProps. This occurs in the idyll document component and several components in idyll components, including at least the table component. To fix, first try running the recommended codemod: `npx react codemod rename unsafe lifecycles` from the project root. Then manually check any remaining warnings in the browser console. Focus on the src directory, especially files under packages/idyll document and packages/idyll components. Ensure all usages of the deprecated methods are renamed. There are no linked PRs or comments, so this issue is available for a first time contributor.