idyll-lang/idyll

Idyll Editor Variable Hoisting Issue

Open

#671 opened on Nov 17, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,977 stars) (97 forks)batch import
DocsEditorRough Edgeshelp wanted

Description

Describe the bug In the Idyll Editor, inserting a variable between a pre-existing variable tag and a pre-existing non-variable tag seems to not hoist the new variable correctly and doesn't bind to other tags that refer to it.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://idyll-lang.org/editor
  2. Delete all the example text
  3. Type in:
[var name:"a" value:1 /]
[display value:a /]

This should render "1.00" correctly on the right hand side.

  1. Type [var name:"b" value:2 /] in between the two tags and change the display value to "b"
[var name:"a" value:1 /]
[var name:"b" value:2 /] // added 
[display value:b /] // change to "b"

The display will disappear and the change to the value "2" won't be registered

Expected behavior Variables should be registered and usable regardless of where they are inserted in the editor (since they are hoisted by the compiler). In the example, the Display component should change to "2.00" and not go blank.

Screenshots var_editor_bug

Additional context From Gitter convo regarding adding a frequency variable to the sin chart example

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the Idyll compiler's variable hoisting mechanism, likely in packages/idyll compiler. Look for how variables are collected and bound in the AST, particularly when inserting a variable declaration between existing variable and non variable tags. Check the editor's handling of insertion order and reprocess compilation. No linked PRs or comments provide additional clues.