idyll-lang/idyll

Nested unordered lists don't work

Open

#653 opened on Jun 30, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,977 stars) (97 forks)batch import
Compilerbughelp wanted

Description

Describe the bug Nested unordered lists don't seem to work correctly.

To Reproduce

* AAA
* BBB
* CCC
    * DDD
    * EEE
* FFF

Expected behavior The page should show an unordered list containing items AAA, BBB, CCC, and FFF, and a nested unordered list under item CCC containing items DDD and EEE.

Screenshots Current (incorrect) Idyll output for the above markdown: image

For comparison, here's Jekyll's (correct) output for the same markdown: image I also checked this in GitHub's markdown readme renderer, and it's the same as Jekyll's.

Desktop (please complete the following information):

  • OS: KDE Neon 5.19 (Ubuntu 18.04)
  • Chromium
  • 83.0.4103.61 (Official Build)

Additional context Based on the structure of the HTML output, Idyll seems to interpret this example as three separate top-level lists: (AAA, BBB, CCC), (DDD), (EEE, FFF).

I tried varying the indentation and the bullet characters; this didn't seem to change anything.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of markdown parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the markdown parsing logic in the Idyll compiler, likely in files related to the AST or markdown to Idyll conversion. Check the existing parsing of list nodes and how nesting is handled. Look at the generated HTML structure to identify where the nesting logic fails.