idyll-lang/idyll

Components emit dirty markup

Open

#628 opened on Apr 22, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (97 forks)batch import
ComponentsRough Edgesbughelp wanted

Repository metrics

Stars
 (1,977 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug Some components emit markup like this: div idyll="[object Object]">... This happens due to using the {...props} syntax in the components' render functions.

Expected behavior The HTML should not contain idyll="[object Object]".

To Reproduce Just look at any page made with idyll, the default project works fine.

Contributor guide

Research direction
Identify the components that use `{...props}` and ensure that only valid HTML attributes are passed through, possibly by filtering out non standard props like `idyll`.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75