idyll-lang/idyll

Components emit dirty markup

Open

#628 opened on Apr 22, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,977 stars) (97 forks)batch import
ComponentsRough Edgesbughelp wanted

Description

Describe the bug Some components emit markup like this: div idyll="[object Object]">... This happens due to using the {...props} syntax in the components' render functions.

Expected behavior The HTML should not contain idyll="[object Object]".

To Reproduce Just look at any page made with idyll, the default project works fine.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Identify which components in the idyll codebase use `{...props}` in their render functions. Examine the component rendering logic to determine where the spread operator causes `[object Object]` to appear in the HTML. Then modify the component to filter out non string props or use a different approach to avoid spreading non standard properties onto the DOM element.