idurar/idurar-erp-crm

Able to add fields in invoices without item name

Open

#207 opened on Jul 8, 2023

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (4,308 stars) (1,036 forks)batch import
good first issue🎨 Frontend🐛 bug

Description

image

Hey I dont think users should be able to add fields in the invoices without an item name. I just entered spaces on the item name and item name field isn't treating it as empty string. Also I am able to enter quantities in points like 0.1, 0.3 and even 0. I think that too shouldn't be allowed because quantities in points or 0 doesn't make sense. This is a minor bug which needs to be fixed. Can you assign this to me so I can fix this bug?

Contributor guide

Tech stack
javascriptreactnodejsexpressmongodb
Domain
frontendbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue requires adding validation to prevent empty item names (only spaces) and non positive integer quantities in invoice items. Examine the invoice creation form component (likely in React) for frontend validation. Also check the backend API endpoint for invoice creation (likely Node.js/Express) to add server side validation for the item name and quantity fields. The item name should be trimmed and checked for emptiness, and quantity should be an integer greater than 0. Look at existing validation patterns in the codebase for consistency.