ideal-co/ogre

Prometheus Web Server Should Attempt Restarts

Open

#24 opened on Jun 1, 2020

 (0 comments) (0 reactions) (0 assignees)Go (2 forks)auto 404
backendgood first issue

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

Description:

There is a server spun off in a go routine when the prometheus backend is configured, this server should be hardened to handle errors and restarts as necessary as it currently is as simple as:

	// expose the handler and start the server to be scraped
	http.Handle(pbe.MetricPath, promhttp.Handler())
	go func() {
		err := http.ListenAndServe(server, nil)
		if err != nil {
			log.Daemon.Errorf("error starting prometheus server: %s", err)
		}
	}()

Contributor guide