ide/hapi-async-handler

Failure with latest hapi, typescript etc.

Open

#13 opened on Dec 12, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (7 forks)github user discovery
help wanted

Repository metrics

Stars
 (44 stars)
PR merge metrics
 (PR metrics pending)

Description

I get a fatal error if I combine hapi-async-handler (1.0.3) with hapi 16.0.1, asyncfile 2.0.2, node 7.0 and typescript 2.1. The process outputs the following and the request stalls.

(node:5494) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: text.replace is not a function (node:5494) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Example handler:

handler: async function (request: hapi.Request, reply: hapi.IReply) {
        let newsFile = Path.join(assets_folder, 'news.md');
        let input = await fs.readFile(newsFile);

        let converter = new showdown.Converter();
        let html = converter.makeHtml(input);
        reply(html);
      },

Contributor guide

Research direction
Inspect the async handler function and trace the return value type. The error 'text.replace is not a function' suggests that a non string value (e.g., Buffer) is being passed where a string is expected. Check the `reply` call and the result of `makeHtml`.
Tech stack
javascripttypescriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65