icsharpcode/SharpZipLib

Zip-as-a-browser-download-attachment doesnt work in .Net Core 2.0

Open

#194 opened on Oct 3, 2017

View on GitHub
 (4 comments) (1 reaction) (0 assignees)C# (3,502 stars) (964 forks)batch import
core streamdocumentationhelp wantedzip

Description

The sample for creating a zip fie as a browser download attachment as mentioned at doesnt seem to work in .Net Core 2.0:

https://github.com/icsharpcode/SharpZipLib/wiki/Zip-Samples#create-a-zip-as-a-browser-download-attachment-in-iis

In the sample code, I think Response.Flush(); need to be updated to Response.Body.Flush(); whereas Response.End();, need to be removed.

But I am not sure what Response.OutputStream should be updated with? It seems that in .net core 2.0 Response.OutputStream is not available.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C#ASP.NET Core basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue references the SharpZipLib wiki sample for creating a zip as a browser download attachment. The main challenge is that .NET Core's HttpResponse does not have an OutputStream property. Research how to write to the response body using a Stream in ASP.NET Core 2.0, specifically using Response.Body.WriteAsync or similar. Also note that Response.Flush() should be replaced with Response.Body.FlushAsync() and Response.End() is not available; instead, you should complete the response properly. Look at the current SharpZipLib source code for any existing zip stream examples.