icsharpcode/ILSpy

When navigating to an overridden virtual method from the overriding derived class, navigate to the overridden method

Open

#819 opened on Jul 5, 2017

View on GitHub
 (1 comment) (2 reactions) (0 assignees)C# (25,162 stars) (3,645 forks)batch import
Help WantedUI

Description

Consider the following class structure:

class Base 
{
    public virtual int Foo() { return 42; }
}

sealed class Derived : Base
{
    public override int Foo() { return 123; }
    public int Bar() { return this.Foo(); }
}

Suppose I'm looking at Derived::Bar, and I click Foo(). I am currently taken to Base::Foo which is misleading because in actuality Derived::Foo will be called.

I made Derived sealed just to drive my point further, obviously even if it's non-sealed Derived::Foo would be a better guess.

Contributor guide

Tech stack
csharp
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#virtual methods
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the navigation code in ILSpy that resolves method references when clicking a call. Currently, it seems to navigate to the base method. The fix involves adding context aware resolution that prefers the overriding method in the derived class when the call is made from a derived class. Look for relevant files in the ILSpy source, such as those handling symbol navigation or decompilation. Check any existing comments or linked issues for additional context.