icsharpcode/ILSpy

delegate addition not using +=

Open

#1755 opened on Oct 21, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C# (25,162 stars) (3,645 forks)batch import
C#DecompilerEnhancementHelp Wanted

Description

Ver. tested: d2f72583 Tested with multiple csc compilers.

class C
{
    public delegate void Del_t();
    Del_t dels;
    public void fn()
    {
        dels += cb;
    }
    private void cb() {}
}

Expected: fn to decompile to src form. Actual:

public void fn()
{
    dels = (Del_t)Delegate.Combine(dels, new Del_t(cb));
}

I could have sworn this used to work. Have I been dreaming? Is it a regression?

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C# delegatesILSpy architecturedecompilation concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the decompilation of delegate addition in ILSpy. Check if the issue is a regression by looking at git history for changes in delegate handling. Examine the CSharpDecompiler or related classes for how `+=` is transformed. Consider reaching out in comments for more context.