icsharpcode/ILSpy

Implement Roslyn formatting options in the decompiler

Open

#1088 opened on Mar 11, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (25,162 stars) (3,645 forks)batch import
C#DecompilerHelp WantedNew FeatureOutput

Description

As we are now part of Roslyn, it would be nice to support all the formatting options that Roslyn exposes (plus new ones dotnet/roslyn#25303).

  1. Copy Roslyn's CSharpFormattingOptions into ICSharpCode.Decompiler.CSharp.Output replacing all options with plain bool/enum properties, so we use the same names as Roslyn does for the options, but don't have a dependency on Roslyn.
  2. Implement the options in CSharpOutputVisitor.
  3. Extend the Roslyn integration to pass the current options to the decompiler.

Contributor guide

Tech stack
csharp
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#RoslynILSpy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue outlines three steps: copy Roslyn's CSharpFormattingOptions into the decompiler, implement the options in CSharpOutputVisitor, and extend the Roslyn integration to pass options. The referenced Roslyn issue (dotnet/roslyn#25303) provides context for the desired formatting options. The main files to modify are likely in the ICSharpCode.Decompiler.CSharp.Output namespace. The issue is old and may require updating to current Roslyn APIs.