icsharpcode/ILSpy

Implement Roslyn formatting options in the decompiler

Open

#1,088 opened on Mar 11, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (3,645 forks)batch import
C#DecompilerHelp WantedNew FeatureOutput

Repository metrics

Stars
 (25,162 stars)
PR merge metrics
 (Avg merge 15d 22h) (61 merged PRs in 30d)

Description

As we are now part of Roslyn, it would be nice to support all the formatting options that Roslyn exposes (plus new ones dotnet/roslyn#25303).

  1. Copy Roslyn's CSharpFormattingOptions into ICSharpCode.Decompiler.CSharp.Output replacing all options with plain bool/enum properties, so we use the same names as Roslyn does for the options, but don't have a dependency on Roslyn.
  2. Implement the options in CSharpOutputVisitor.
  3. Extend the Roslyn integration to pass the current options to the decompiler.

Contributor guide

Research direction
Copy Roslyn's CSharpFormattingOptions into ICSharpCode.Decompiler.CSharp.Output, then implement each formatting option in CSharpOutputVisitor by mapping to existing or new formatting logic. Finally, extend the Roslyn integration to pass the settings from the IDE to the decompiler.
Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60