icloud-photos-downloader/icloud_photos_downloader

remove download directory from progress-bar

Open

#173 opened on Oct 16, 2020

View on GitHub
 (11 comments) (2 reactions) (1 assignee)Python (502 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (5,348 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently the full download path is shown in the progress bar line. If the download path given by "-d" is pretty long, this leads to a "flickering" for longer filenames. To reduce this I suggest removing everything given by "-d" from the path and only show the directory sub-structure+filename and omit the base dir as it is given out on INFO the line before anyways.

I'd like some opinions before implementing

Contributor guide

Research direction
Locate the progress bar display code in the repository. Identify where the download path is constructed and shown. Modify it to remove the base directory path given by the d option. Test the change by running the tool with a long path.
Tech stack
python
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80