iced-rs/iced

Widget states should implement standard traits eagerly

Open

#790 opened on Mar 21, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (30,491 stars) (1,572 forks)batch import
featuregood first issuequestionwidget

Description

The builtin widgets' states should implement standard traits (notably PartialEq) eagerly.

It would be convenient for me to #[derive(PartialEq)] for my app state. Unfortunately, it contains text_input::State which doesn't impl it (but it could).

Contributor guide

Tech stack
rust
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingUnderstanding of PartialEq trait
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the source code of Iced's builtin widgets (e.g., text input, button, etc.) to find all state structs. For each state struct, determine if all its fields implement PartialEq. If so, add `#[derive(PartialEq)]` to the struct. If some fields are not PartialEq, consider manual implementation or changing field types. The issue specifically mentions `text input::State` as a candidate. Ensure no breaking changes and that the change compiles.
Widget states should implement standard traits eagerly · iced-rs/iced#790 | Good First Issue