iced-rs/iced

Superfluous alignment functions

Open

#286 opened on Apr 11, 2020

View on GitHub
 (7 comments) (5 reactions) (0 assignees)Rust (1,572 forks)batch import
good first issuehelp wantedlayoutquestion

Repository metrics

Stars
 (30,491 stars)
PR merge metrics
 (Avg merge 24d 11h) (11 merged PRs in 30d)

Description

The current api exposes multiple ways for alignment to be expressed:

  • Container::center_x is equivalent to Container::align_x(Center)
  • HorizonalAlignment, VerticalAlignement, and Align all express the same concept.

These introduce more names and relationships for users to learn about in the api, and I think reducing them would be positive. could we remove them?

Contributor guide

Research direction
Identify all usages of Container::center x, HorizontalAlignment, VerticalAlignment, and Align in the codebase. Remove the redundant functions and update any dependent code and tests.
Tech stack
rust
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75