iced-rs/iced

Superfluous alignment functions

Open

#286 opened on Apr 11, 2020

View on GitHub
 (7 comments) (5 reactions) (0 assignees)Rust (30,491 stars) (1,572 forks)batch import
good first issuehelp wantedlayoutquestion

Description

The current api exposes multiple ways for alignment to be expressed:

  • Container::center_x is equivalent to Container::align_x(Center)
  • HorizonalAlignment, VerticalAlignement, and Align all express the same concept.

These introduce more names and relationships for users to learn about in the api, and I think reducing them would be positive. could we remove them?

Contributor guide

Tech stack
rust
Domain
frontenddeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingIced API basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the alignment related code in the Iced codebase, specifically `Container::center x` and `Container::align x` methods and the alignment enums (`HorizontalAlignment`, `VerticalAlignment`, `Align`). Check existing tests and documentation for these functions. Consult the issue comments (#286) for any maintainer guidance on preferred approach. Implement removal or deprecation with corresponding updates to docs and changelog.