ianyh/Amethyst

BSP creates new windows in the same "tree" that they were spawned from

Open

#482 opened on Aug 7, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Swift (16,121 stars) (516 forks)batch import
bughelp wanted

Description

I don't know if this is meant to be a feature, but I see this strange behavior with BSP in 0.11.0b where creating a new window with command + N causes the new window to be added to the window or "tree" of the window currently selected. So if I have the left main pane window (let's say, Chrome) selected, and hit command + N a couple times, I will see a bunch of small windows on the left hand side of the screen, not on the lower right, where I would expect.

Trello Card

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SwiftmacOSAmethyst codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the BSP layout algorithm in the source code, particularly in files related to window management (e.g., BSPWindow.swift or similar). Look at how new windows are placed when spawned from a focused window. The issue suggests that new windows are added to the same subtree instead of splitting the space. A possible fix involves modifying the split logic to ensure new windows are created in the opposite side of the current split. Review any existing tests for window placement.