ianyh/Amethyst

Weird BSP behavior when float small windows enabled

Open

#480 opened on Aug 7, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (16,121 stars) (516 forks)batch import
bughelp wanted

Description

When float small windows is enabled with 0.11.0b, if you keep creating new windows they eventually end up being floated. This may be because the window is resized by BSP to be below the threshold for floating small windows. Amethyst shouldn't be treating windows as "small" if it was responsible for making them so!

Trello Card

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of Amethyst's BSP layout algorithmknowledge of Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the BSP layout code related to window resizing and the floating small windows threshold. The issue suggests that Amethyst resizes windows below the threshold, causing them to float. Check the linked Trello card for additional context. Focus on the logic that determines when to float windows and ensure it does not float windows that were resized by Amethyst itself.