ianyh/Amethyst

Padding settings do not immediately apply

Open

#351 opened on Nov 15, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (16,121 stars) (516 forks)batch import
bughelp wantedstarter issue

Description

Remaining from the pull request #298.

Amethyst does not trigger changes when changing padding settings, windows need to be resized manually before the new padding is applied or Amethyst needs to be restarted.

The cause of this is both that windows needs to be marked as needing resizes whenever a setting related to padding changes and the leeway for resizes (Amethyst does not consider any window to need a resize if the window padding is smaller than this).

Trello Card

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftmacOS window manager conceptsAmethyst codebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the changes in pull request #298 to understand the partial fix. Examine the code that handles padding settings, likely in a settings manager or window layout class. Identify where windows are marked as needing resize and add the necessary call when padding settings change. Also check the leeway for resizes as mentioned in the issue.