ianyh/Amethyst

Can't float the 'Add to Todoist' pop up in Brave Browser.

Open

#1410 opened on Feb 7, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (16,121 stars) (516 forks)batch import
bughelp wanted

Description

Describe the bug When right clicking on a webpage and adding to Todoist the pop up always stretches to full screen in line with Amethyst settings, despite adding the title of the window (and some attempted variants) to the float settings.

Applications: Todoist & Brava Browser

To Reproduce Right click and 'Add to Todoist'

Expected behavior The pop up window floats without enlarging to full screen

Screenshots

Versions:

  • macOS:
  • Amethyst:

Debug Info

$ /Applications/Amethyst.app/Contents/MacOS/Amethyst --debug-info [--include-apps]

Note: --include-apps will list your manageable applications, but is optional if you don't want to list that.

Additional context Add any other context about the problem here.

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of Amethyst window managementFamiliarity with macOS window titlingAbility to test with Brave browser and Todoist
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the window identification logic in Amethyst, likely in files like `Window.swift` or `Configuration.swift`. Determine how the app matches windows to float rules (e.g., by title, bundle ID, or other properties). Test with the Todoist popup in Brave to see what properties the window has, and consider if a more flexible matching or a new rule is needed. No previous PRs or comments exist for this issue.