ianyh/Amethyst

Move focus to floating windows.

Open

#1069 opened on Nov 15, 2020

View on GitHub
 (1 comment) (3 reactions) (0 assignees)Swift (16,121 stars) (516 forks)batch import
discussion neededenhancementhelp wanted

Description

I'm always frustrated when I use mod+j/k(move focus clockwise/countclockwise) to move focus out from float windows but never move it back. This behaviour is not consistent.

Personally, I'd like floating windows could always be viewed with mod+j/k.

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftmacOS window managementAmethyst architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue requests that the focus cycling commands (mod+j/k) also cycle into floating windows. Currently, they only move between tiled windows. To implement this, you would need to modify the focus handling logic in Amethyst, likely in files related to window management or keyboard shortcuts. Review the existing focus cycle code to understand how it skips floating windows and adjust it to include them. The issue has no comments or linked PRs, so start by exploring the repository's source code structure.