iamkun/dayjs

🎁 2.0 Milestones【Breaking Change】

Open

#1,281 opened on Dec 19, 2020

View on GitHub
 (38 comments) (17 reactions) (0 assignees)JavaScript (48,643 stars) (2,426 forks)batch import
Breaking Changediscussionhelp wanted🚨 High Priority

Description

We want to make some changes to make Day.js modern and in a standard JS way.

And this would be a breaking change because of these changes below:

Make TypeScript definition the same behavior as JS code

Update types/index.d.ts to export default dayjs;

Mark the correct ES6 Module entry

Update package.json "module" to "esm/index", (won't introduce in "dayjs", see https://github.com/iamkun/dayjs/issues/1281#issuecomment-754381268)

Publish a new NPM package, maybe "dayjs-esm" to ship an ESM module with package.json module entry pointed to. ref https://github.com/iamkun/dayjs/issues/1242#issuecomment-734321931

Contributor guide

🎁 2.0 Milestones【Breaking Change】 · iamkun/dayjs#1281 | Good First Issue