iamcco/markdown-preview.nvim

Autoclose not working

Open

#316 opened on Mar 20, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (5,538 stars) (246 forks)batch import
help wanted

Description

Describe the bug I have enabled mkdp_auto_close. Yet when I do :MarkdownPreviewStop or when I close the buffer, the preview window doesn't close

To Reproduce Steps to reproduce the behavior:

I have set mkdp_browserfunc to the following

  function OpenURL(url)
    execute 'silent' '!qutebrowser' '--target' 'private-window' shellescape(a:url)
  endfunction

Expected behavior The preview window to close when closing the buffer.

Desktop (please complete the following information):

  • OS: 5.11.7-arch1-1

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Vim plugin configurationBasic understanding of browser function
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the autoclose functionality in markdown preview.nvim. Check if the custom browser function (qutebrowser) is properly handled. Look at the source code for the ClosePreview command and autoclose logic. Consider if there is an issue with the window detection when using a non default browser.