iamcco/markdown-preview.nvim

Autoclose not working

Open

#316 opened on Mar 20, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (246 forks)batch import
help wanted

Repository metrics

Stars
 (5,538 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug I have enabled mkdp_auto_close. Yet when I do :MarkdownPreviewStop or when I close the buffer, the preview window doesn't close

To Reproduce Steps to reproduce the behavior:

I have set mkdp_browserfunc to the following

  function OpenURL(url)
    execute 'silent' '!qutebrowser' '--target' 'private-window' shellescape(a:url)
  endfunction

Expected behavior The preview window to close when closing the buffer.

Desktop (please complete the following information):

  • OS: 5.11.7-arch1-1

Contributor guide

Research direction
Check the autoclose implementation and event listeners in the plugin code.
Tech stack
javascript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75