hyperstack-org/hyperstack

a Native::Object in component params can't be retrieved

Open

#417 opened on Jul 16, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
buggood first issue

Description

A Native::Object is a BasicObject and it doesn't respond to "tap". It defines method_missing so Native::Object.new.tap returns nil

At hyperstack/ruby/hyper-component/lib/hyperstack/internal/component/props_wrapper.rb:113 .tap returns nil so fetch_from_cache returns nil instead of the Native::Object.

I suggest to rewrite fetch_from_cache without using tap.

Contributor guide

Tech stack
ruby
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RubyBasicObject
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue points to the file `hyperstack/ruby/hyper component/lib/hyperstack/internal/component/props wrapper.rb` at line 113. The current implementation uses `.tap` which fails on `Native::Object` since it is a `BasicObject` that does not respond to `tap`. The fix is to rewrite the `fetch from cache` method without using `tap`, for example by storing the value in a variable and then returning it. Check the comments for any additional context or maintainer input.
a Native::Object in component params can't be retrieved · hyperstack-org/hyperstack#417 | Good First Issue