hyperstack-org/hyperstack

Hyperspec to_js method broken

Open

#393 opened on Mar 31, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
buggood first issue

Description

    def to_js(*args, &block)
      opal_compile(*process_params(*args, &block))
    end

needs to be

    def to_js(*args, &block)
      opal_compile(process_params(*args, &block).first)
    end

(second value from process_params is options for mounting, which opal_compile doesn't need)

Should have a simple spec anyway that says yes I returned a string with length > 0

Contributor guide

Tech stack
None
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic RubyOpal basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Apply the one line fix in the `to js` method: wrap `process params(*args, &block)` with `.first` to pass only the first argument to `opal compile`. Then add a simple spec that verifies `to js` returns a non empty string. Locate the file containing the method (likely in the Hyperspec source) and make the change, then write a test to confirm the behavior.