hyperstack-org/hyperstack

Hyperspec to_js method broken

Open

#393 opened on Mar 31, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (43 forks)batch import
buggood first issue

Repository metrics

Stars
 (531 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

    def to_js(*args, &block)
      opal_compile(*process_params(*args, &block))
    end

needs to be

    def to_js(*args, &block)
      opal_compile(process_params(*args, &block).first)
    end

(second value from process_params is options for mounting, which opal_compile doesn't need)

Should have a simple spec anyway that says yes I returned a string with length > 0

Contributor guide

Research direction
Modify the to js method to use only the first element from process params, as the second is for mounting options and opal compile expects a single params hash.
Tech stack
ruby
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90