hyperstack-org/hyperstack

`Object#loaded?` and `Object#unloaded?` should be defined on the server

Open

#320 opened on Oct 19, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
enhancementgood first issue

Description

These methods are only useful on the client, but for isomorphic methods they should be also defined on the server. On the server loaded? should always return true, and unloaded? always returns false.

Contributor guide

Tech stack
javascript
Domain
full stack
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The issue is straightforward: implement Object#loaded? and Object#unloaded? on the server side to always return true and false respectively. The client side implementations likely exist in the Hyperstack Opal codebase. Look in the Ruby source files under lib/ for existing definitions of these methods on Object, and then add server side equivalents, possibly in a separate module or top level definition. The change is localized and requires no additional dependencies.