hyperstack-org/hyperstack

should `extract_css` be true?

Open

#286 opened on Nov 23, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
discussionhelp wantedneeds doc

Description

In config/webpacker.yml the extract_css option is currently false unless in production, but this seems to break importing predefined styles.

Should it be true?

In the meantime if you are trying to include styles from an npm module (i.e. bootstrap) do the following:

  1. create app/javascript/packs/styles.js file and import the style sheets you want.
  2. add <%= style_sheet_pack_tag 'styles' %> to your layout files.
  3. set extract_css: true in config/webpacker.yml

Currently trying to find an answer to why this is all necessary here: https://stackoverflow.com/questions/59009216/how-to-get-webpacker-to-load-css-if-extract-css-is-false

Contributor guide

Tech stack
javascriptrubyrailscss
Domain
frontendbuild system
Issue type
documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RailsWebpackerCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue asks whether `extract css` should default to true in `config/webpacker.yml`. The first step is to understand the purpose of `extract css` in the webpacker configuration and how it affects CSS loading. Check the webpacker documentation and the repository's own configuration for guidance. Also, review any existing discussions or PRs related to this setting. Finally, test the behavior with both `true` and `false` values to see the impact on importing predefined styles from npm modules.
should `extract_css` be true? · hyperstack-org/hyperstack#286 | Good First Issue