hyperstack-org/hyperstack

webpacker integration does not pull in .css packs

Open

#266 opened on Oct 7, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
bughelp wanted

Description

If you require css files in the client_only and client_and_server pack files, they do not get included in the required assets.

Not sure if this is practical or possible. Currently hyper-config pulls in the pack file by doing an opal require on them. But if you try to require a css file it doesnt' like it.

The work around is to add one or both these lines to the layouts, if you are requiring css assets in the pack files: <%= stylesheet_pack_tag 'client_only' %>
If you are requiring css libraries in the client_only.js pack file
and
<%= stylesheet_pack_tag 'client_and_server' %>
If you are requiring css libraries in the client_and_server.js pack file

Contributor guide

Tech stack
rubyrailsjavascriptcss
Domain
frontendbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Ruby on Railswebpackerhyperstack basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate how hyperstack's hyper config processes pack files and why .css files are skipped. Look at the code that requires pack files in the Ruby gem. Consider modifying the require logic to include CSS assets or adding a webpacker configuration to handle stylesheet pack tags. The workaround suggests adding stylesheet pack tag manually in layouts, so the goal is to automate this.