hyperstack-org/hyperstack

default for boolean dummy values not working

Open

#261 opened on Oct 3, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (43 forks)batch import
buggood first issue

Repository metrics

Stars
 (531 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

for booleans, the following default values in the schema should be recognized as true, anything else is false:

'1', true or 1

i.e. in ReactiveRecord::Base::DummyValue

      def build_default_value_for_boolean
        @column_hash[:default] == '1' || @column_hash[:default] == true || @column_hash[:default] == 1
      end

Contributor guide

Research direction
Locate the file containing the `build default value for boolean` method in the Hyperstack codebase, and update the condition to also check for '1', true, or 1 as specified.
Tech stack
ruby
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80