hyperstack-org/hyperstack

default for boolean dummy values not working

Open

#261 opened on Oct 3, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
buggood first issue

Description

for booleans, the following default values in the schema should be recognized as true, anything else is false:

'1', true or 1

i.e. in ReactiveRecord::Base::DummyValue

      def build_default_value_for_boolean
        @column_hash[:default] == '1' || @column_hash[:default] == true || @column_hash[:default] == 1
      end

Contributor guide

Tech stack
ruby
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic RubyFamiliarity with ActiveRecord
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The issue is in the file ReactiveRecord::Base::DummyValue (likely within the hyperstack Ruby gem). The method build default value for boolean needs to be corrected to match the described default values. See the code snippet in the issue for the current implementation and the expected behavior.