hyperstack-org/hyperstack

trying to destroy an item that is not included in the default scope fails

Open

#260 opened on Oct 3, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
good first issue

Description

If you have a default_scope (other than just all) then some records are not included by a simple query. However you can get you can override the default scope using unscoped. This means you can get the id of records that are not in the default scope.

If you try to destroy one of those records, it doesn't work.

Fix would be on about line 590 of isomorphic_base.rb in the server side destroy_record method. Just change model.find(id) to model.unscoped.find(id)

Contributor guide

Tech stack
rubyrails
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Ruby on RailsActiveRecord
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look at the `destroy record` method in `isomorphic base.rb` around line 590. The fix is to change `model.find(id)` to `model.unscoped.find(id)`. Ensure the change works with all model scopes and add a test case for destroying records excluded by default scopes.