hyperstack-org/hyperstack

supply default method for events

Open

#247 opened on Sep 2, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (531 stars) (43 forks)batch import
enhancementgood first issue

Description

Currently if no callback is supplied for the event, nothing happens, and firing the event returns nil.

It might be handy be able to supply a default action.

i.e. fires save: :default_save_method

currently you can work around this by checking props[event_name] for nil

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Explore the event system in Hyperstack by examining where events are defined and fired. Look for the `fires` method implementation and the code that checks `props[event name]` to understand the current behavior. Then design a solution to allow a default callback as a second argument to `fires`. Consider backward compatibility and the workaround mentioned in the issue.
supply default method for events · hyperstack-org/hyperstack#247 | Good First Issue