hyperoslo/ImagePicker

Do you think imageDidDrop should calls dismissIfNeeded?

Open

#432 opened on Sep 10, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Swift (619 forks)batch import
help wanted

Repository metrics

Stars
 (4,400 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When imageLimit is set to 1 and touches the photo already selected, the imagePicker dismisses.

Is that what you expected?

I wonder why just touching the selected photo does not deselect the photo.

Contributor guide

Research direction
Investigate the dismissIfNeeded method in the ImagePicker codebase to understand why selecting an already selected photo when imageLimit is 1 causes dismissal instead of deselection. Check the logic for handling imageLimit and touch events on selected images.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75