Review handling of consumed sandboxes in the JS API
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Quiet
- Tech stack
- javascript
- Domain
- api
Research direction
Start by reviewing the JavaScript API's sandbox getters and the discussion linked from pull request #69. Determine the expected behavior when a sandbox has been consumed, then document the chosen API behavior and add or update the relevant tests if the project identifies them.
Written by the indexing model from the issue text.
Description
I am not a big fan of getters throwing errors, as that's an unexpected behaviour for a getter.
At the same time, I am not sure what would be the correct result to return form a consumed sandbox, maybe false? maybe null? but I guess returning null is not too different from throwing.
I propose we leave it as it is right now, and we get someone with more JS API design experience to take a look into it. I'll open an issue so that we don't forget about it.
Originally posted by @jprendes in https://github.com/hyperlight-dev/hyperlight-js/pull/69#discussion_r3073438031
- Dominant language
- Rust
- Stars
- 13
- Forks
- 5
- Avg merge
- 8d 4h
- Merged PRs (30d)
- 14
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperlight-dev/hyperlight-js
-
lifecycle/needs-review
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
lifecycle/needs-review
Difficulty 5/5 Over a week Newbie friendliness 35/100
hyperlight-dev/hyperlight-js#312 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
hyperlight-dev/hyperlight-js#252 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
hyperlight-dev/hyperlight-js#249 ·
-
lifecycle/needs-review
Difficulty 4/5 3-5 days Newbie friendliness 35/100
hyperlight-dev/hyperlight-js#223 ·
All issues in hyperlight-dev/hyperlight-js
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
state:needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
zed-industries/zed#64680 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
RustPython/RustPython#8802 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
TheLarkInn/aipm#2390 ·