`IfNoneMatch::decode()` returns and empty `ETag` even if the iterator passed to it is empty
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- rust
- Domain
- networking
Research direction
Start at the IfNoneMatch::decode entry point and reproduce the behavior with the empty-iterator test shown in the issue. Trace how an empty iterator is handled, then verify that an empty input returns an error and that valid If-None-Match values still decode successfully.
Written by the indexing model from the issue text.
Description
use headers::{IfNoneMatch, Header};
#[test]
fn test_empty_if_none_match() {
let mut iter = std::iter::empty();
let if_none_match = IfNoneMatch::decode(&mut iter);
assert!(if_none_match.is_err()); // This assert fails. `decode` returns `Ok(IfNoneMatch(Tags("")))`
}
This means that even if there's no IfNoneMatch header in the request, this'll still report it as present.
- Dominant language
- Rust
- Stars
- 200
- Forks
- 107
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperium/headers
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 3/5 1-2 days Newbie friendliness 78/100
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Link support Open
Difficulty 4/5 3-5 days Newbie friendliness 38/100
All issues in hyperium/headers
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
issue
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
agentic-workflows
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
web-infra-dev/rspack#15847 ·