huginn/huginn

WebsiteAgent - Merge should be a property apart

Open

#1,369 opened on Mar 23, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Ruby (4,264 forks)batch import
help wanted

Repository metrics

Stars
 (49,270 stars)
PR merge metrics
 (Avg merge 4d 2h) (15 merged PRs in 30d)

Description

In WebsiteAgent, the modeparameter accepts three options: all, on_change and merge. Thus, we do not have the ability to create new events merged only when there is change.

Do you think it makes more sense to have only 2 modes: all and on_change?

The option to merge or not merge should be an agent property.

By the way, this property could be in ALL the agents that receive and send events.

Contributor guide

Research direction
Review the current implementation of WebsiteAgent’s mode parameter and discuss the design trade offs of making merge a separate property across all agents. Provide examples of how the change would affect existing behavior and suggest a migration path.
Tech stack
ruby
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRubyHuginn
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70