hughsk/chrome-location

Support Chromium browser

Open

#7 opened on Dec 22, 2015

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (6 forks)github user discovery
help wanted

Repository metrics

Stars
 (19 stars)
PR merge metrics
 (PR metrics pending)

Description

I am using Chromium Version 47.0.2526.73 on Ubuntu 15.10 (64-bit) and thus, I get undefined when requiring chrome-location:

> require('chrome-location');
undefined

To make things work in my case, I just had to change line 8 of index.js like this:

module.exports = require('which').sync('chromium-browser')

Contributor guide

Research direction
Look at line 8 of index.js and test if changing 'google chrome' to 'chromium browser' works on Chromium based systems.
Tech stack
javascriptnodejs
Domain
toolingcli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80