RLOOTrainer & PPOv2Trainer - Modify Name for W&B Logged Table
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- python
- Domain
- machine-learning
Research direction
Start with the W&B table logging statements at trl/trainer/rloo_trainer.py#L511-L512 and trl/trainer/ppov2_trainer.py#L613-L614. Review how self.state.global_step is available at those entry points, then update the table naming so completions from different training steps remain separately inspectable in W&B. Done means both trainers produce step-specific table names.
Written by the indexing model from the issue text.
Description
Feature request
RLOOTrainer and PPOv2Trainer both log a table to W&B titled "completions". I would like the name to be changed to f"completions_step={self.state.global_step}" or something like this.
Motivation
Due to how W&B displays tables in the WebUI, logging the table under the same name "completions" means that one can only see the most recent table of completions, rather than tables of completions at different points during learning.
I would like to be able to manually inspect how completions are changing during learning.
I can probably pull this information out of the W&B API, but this is too much effort. I want to be able to manually inspect easily.
Your contribution
I would be happy to submit a PR for this.
- Dominant language
- Python
- Stars
- 19.3k
- Forks
- 3k
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 182
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from huggingface/trl
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
huggingface/trl#7198 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
huggingface/trl#7086 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
huggingface/trl#7049 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
huggingface/trl#7025 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
huggingface/trl#7015 · 3 comments ·
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100