huan/file-box

Get rid of deprecated Node.js API: url.parse

Open

#20 opened on Jun 22, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (58 stars) (9 forks)user submission
bughelp wanted

Description

https://github.com/huan/file-box/blob/3788e591fad15a2ec00868a3150d1e136e3898dc/src/misc.ts#L90-L98

If we use new url.URL() to replace url.parse, the unit tests will fail, and the reason still needs to be found.

url.parse

Url {
  protocol: 'https:',
  slashes: true,
  auth: null,
  host: 'httpbin.org',
  port: null,
  hostname: 'httpbin.org',
  hash: null,
  search: null,
  query: null,
  pathname: '/headers',
  path: '/headers',
  href: 'https://httpbin.org/headers' }

new url.URL

URL {
  href: 'https://httpbin.org/headers',
  origin: 'https://httpbin.org',
  protocol: 'https:',
  username: '',
  password: '',
  host: 'httpbin.org',
  hostname: 'httpbin.org',
  port: '',
  pathname: '/headers',
  search: '',
  searchParams: URLSearchParams {},
  hash: '' }
https://httpbin.org/headers

Contributor guide

Tech stack
typescriptnodejs
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.js URL APITypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the file src/misc.ts at lines 90-98 to see the current usage of url.parse. Review the unit tests to understand why they fail when using new url.URL(). The difference in output properties (e.g., auth vs username/password) may affect test assertions. Look for existing test files and consider adapting assertions to match WHATWG URL API output.