http-party/http-server

When using https display https://common_name:8080/ as one of the valid hostnames

Open

#670 opened on Dec 27, 2020

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (1,497 forks)batch import
Hacktoberfestgood first issuestale

Repository metrics

Stars
 (13,088 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is a feature request, to display the valid SSL name (from the certificate) when starting up the server.

Steps to reproduce the issue, if applicable. Include the actual command and output and/or stack trace.

$ http-server -S

Starting up http-server, serving ./ through https
Available on:
  https://127.0.0.1:8080
  https://192.168.77.123:8080

What did you expect to happen?

$ http-server -S

Starting up http-server, serving ./ through https
Available on:
  https://127.0.0.1:8080
  https://192.168.77.123:8080
  https://the_name_in_cert.pem:8080

If the issue is a feature request, what is the motivation / use case for it?

To make it easier to:

  1. You are using the correct SSL cert
  2. Easier to click though to a URL that has the valid cert. Both 127.0.0.1 and 192.168.77.123 would display certificate errors.

Tell us about your environment

  • exact http-server version: http-server v0.12.3
  • Node version: Node.js v15.5.0.
  • Platform: MacOs

Other information (related issues, suggestions for a fix, etc):

Contributor guide

Research direction
Investigate how to read the SSL certificate from the server's options (possibly using `https.createServer` options or the `tls` module) and extract the Common Name (CN) from the certificate's subject. Then modify the startup message to include the hostname corresponding to that CN.
Tech stack
nodejsjavascript
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsSSL/TLS basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75