hound-search/hound

Latin charset=ISO-8859-1 parse

Open

#368 opened on Nov 3, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,470 stars) (606 forks)batch import
enhancementhelp wanted

Description

Hi there!

We have localized git, which store translations to languages , therefore ÖÄÕÜ etc ISO-8859-1 compliant files seem to be excluded as "Invalid UTF-8". How to overcome this problem, unfortunately i have no experience with GO to help with PR right now. Help is appreciated. for example: Lähme põõsasse sööma

Contributor guide

Tech stack
go
Domain
clisearch
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of Gocharacter encoding fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how Hound currently reads and validates file content for UTF 8 in the indexing process. Look at the file reading functions in the Go codebase, likely in the 'index' or 'search' package. Consider using the golang.org/x/text/encoding package to detect and convert non UTF 8 encodings such as ISO 8859-1. Check if there are any existing configuration options for encoding. Implement a fallback or detection mechanism to allow Latin 1 encoded files to be indexed without being rejected.