Client does not update object on response failure

Description

var resp client.Response
// finds results
err := client.Search(&resp, cfg, "node-xray", svc, "^package.json", 0, false, false)
// does not find results
err := client.Search(&resp, cfg, "http-shutdown", svc, "^package.json", 0, false, false)
// Expected Behavior - resp holds results from second call.
// Actual Behavior - resp still holding results from first call.

Contributor guide

Tech stack

go

Domain

backendapisearch

Issue type

bug

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

3

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-3 hours

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

stale

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

clear

Prerequisites

Go basicsHTTP client handling

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

65

Research direction

Examine the client.Search function in the Go client code, likely in a file like client.go. The bug is that when Search fails (returns an error), the resp object is not updated and retains the previous result. Look for early returns on error that skip updating resp. A fix should ensure resp is modified or reset even on failure, or the function should not modify resp on error but the caller expects it to hold new results only on success. Check the current implementation to understand the intended behavior and apply a minimal fix.