hound-search/hound

Exceed limit results

Open

#217 opened on Jun 20, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,470 stars) (606 forks)batch import
enhancementhelp wanted

Description

Hi guys, as I can see here https://github.com/etsy/hound/blob/203bd0c7601e28de8c4ae4e922bc0b76938af268/index/index.go#L198 - results are just dropped if they exceed limit (which is constant - 5000).

It is possible to return what was collected so far, instead of just dropping everything. Or, alternatively you can let user set max number of results he wants, of course limited by server's limit too.

For me both are better than what we have now, what do you think?

Contributor guide

Tech stack
go
Domain
backendsearch
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GoRead index.goUnderstand limit logic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the current implementation in index/index.go around line 198 where results are dropped if they exceed the constant limit of 5000. Consider implementing either option: (1) modifying the code to return partial results up to the limit, or (2) adding a configurable limit via user input, with a server side cap. Evaluate which approach is more aligned with the project's goals and discuss with maintainers.