hound-search/hound

Add ability to turn of "git clone --depth=1", it's sometimes quite expensive

Open

#207 opened on May 10, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,470 stars) (606 forks)batch import
enhancementhelp wanted

Description

This was changed in 2e9ceb9 by @kellegous. See this comment to a CocoaPods issue for why using shallow clones for things like this is a bad idea.

IMO this commit should just be reverted, it makes much more sense to do a full clone and then fetch that with the way the fetch protocol works and how shallow clones can trigger bad edgecases in it, but if not please add some config option to turn this off.

Edit: FWIW this isn't some theoretical thing, I have a very large repo that's running into this edge-case, a "pull" should take 2-3s, but sometimes takes up to 6 minutes from hound (a fresh clone is ~3m) because of the edge cases triggered by the shallow clone.

Contributor guide

Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic JavaScriptfamiliarity with gitunderstanding of git clone
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the commit 2e9ceb9 referenced in the issue to understand the shallow clone implementation. Look at relevant code in the repository, likely in git related modules. Consider whether reverting the commit or adding a configuration option is more appropriate. The issue includes a reference to a CocoaPods issue that discusses downsides of shallow clones. No linked PRs or assignees, so first step is to comment on the issue to confirm maintainer interest and possibly propose a plan.