hluk/CopyQ

Double-clicking tray icon opens then closes CopyQ

Open

#2,252 opened on Feb 5, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (419 forks)batch import
Windowsbughelp wanted

Repository metrics

Stars
 (7,372 stars)
PR merge metrics
 (Avg merge 17h 35m) (13 merged PRs in 30d)

Description

Describe the bug Double-clicking CopyQ's tray icon opens then closes CopyQ after a short delay. This is due to the Close When Unfocused option being enabled.

To Reproduce Steps to reproduce the behavior:

  1. Double-click the CopyQ tray icon.

Expected behavior Regardless of single or double-click, or Close When Unfocused state, open the CopyQ window, and stay open. Essentially, if the tray is triggered in quick succession (a double-click), ignore Close When Unfocused logic until a short grace period has passed.

Version, OS and Environment CopyQ 6.4.0 Windows 11 Pro 10.0.22621

Additional context On Windows, some tray icons require only a single-click, others a double-click, to open a program's window, but in all cases that I'm aware of, a program doesn't open then close if a double-click is sent rather than a single-click. Muscle memory shouldn't need changing to accommodate this in my opinion, nor require losing Close When Unfocused functionality.

Contributor guide

Research direction
Examine how tray icon double click events are handled and how the 'Close When Unfocused' option is triggered. Look into Qt's QSystemTrayIcon signal handling and the logic that closes the window when unfocused. Consider adding a grace period after a double click to ignore focus lost events briefly.
Tech stack
c
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Qt
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60