higress-group/higress

支持可以修改Helm部署模板中的controller.name/.Values.gateway.name

Open

#1,101 opened on Jul 8, 2024

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Go (1,144 forks)github user discovery
area/helmhelp wantedlevel/normal

Repository metrics

Stars
 (8,582 stars)
PR merge metrics
 (PR metrics pending)

Description

Ⅰ. Issue Description

Helm模板values参数设计不合理，

  • 1、修改 higress/charts/higress-core/values.yaml 的 .Values.controller.name / .Values.gateway.name 参数之后部署，无法启动 gateway 日志报错
connection error: desc = "transport: Error while dialing dial tcp: lookup higress-controller.ywjkz-prod.svc on 192.168.0.10:53: no such host"`

第一个问题不知道如何修改，我看很多地方用的name都是原生不修改的higress-controller、higress-gateway，不知道哪些参数应该跟着.Values.controller.name / .Values.gateway.name 参数值改变而改变

  • 2、修改 higress/charts/higress-console/values.yaml 的 .Values.service.port 参数之后部署，higress console pod 无法变为running状态

通过查看higress/charts/higress-console/template/deployment.yaml的模板发现，higress-console 的监听端口来源于higress console service的端口值（同时readiness port为containerPort的name），如果我修改了higress console service的类型为loadbalancer，并修改了service port，higress deployment的readinessProbe便会有问题造成无法启动

这个问题可以通过 修改 higress/charts/higress-console/template/deployment.yaml 的 containerPort: {{ .Values.service.port }} 为 containerPort: 8080 解决

Ⅵ. Environment:

  • Higress version: 1.4.1

Contributor guide

Research direction
Trace the usage of .Values.controller.name and .Values.gateway.name across all templates and ensure that every reference to the service name or deployment name uses these values consistently. For the console issue, check the deployment template to ensure the container port is set from a hardcoded default or a separate port value, not from the service port.
Tech stack
gokubernetes
Domain
devopsinfrastructurecloud
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HelmKubernetesGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60