highlightjs/highlight.js

(Java) Generic type variable not highlighted

Open

#4,017 opened on Mar 15, 2024

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (22,960 stars) (3,497 forks)batch import
buggood first issuehelp welcomelanguage

Description

Describe the issue In a Java statement that declares and assigns a variable with a generic type, the type and variable don't get highlighted. Without the generic type they are properly highlighted.

Which language seems to have the issue? java

Are you using highlight or highlightAuto? highlightElement ...

Sample Code to Reproduce

Expected behavior Without the generic type, the type (Map) and variable (params) get highlighted. They should be similarly highlighted also when the generic type is present (and the generic type itself should be highlighted as well).

Additional context The example shows two generic types, but the issue also occurs with a single type such as List. This is the proper way of defining such collections.

Contributor guide

Tech stack
java
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java syntaxhighlight.js grammar APIRegular expressions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Start by examining the Java language grammar file at `src/languages/java.js`. Focus on how type declarations and variable declarations are currently matched. The issue shows that when a generic type like `Map<String, String>` is used, the type and variable name are not highlighted. Look for the rules that handle type names and see if they fail when angle brackets are present. Check if any existing tests cover generic types and add a failing test case. The fix likely involves adjusting the regex or mode for type identifiers to include generic parameters. Review any comments in the issue for additional context; there are 8 comments that might contain insights or partial solutions.
(Java) Generic type variable not highlighted · highlightjs/highlight.js#4017 | Good First Issue