highlightjs/highlight.js

(Rust) Escaped double quotations in string at attribute are not highlighted properly

Open

#3,817 opened on Jul 10, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (22,960 stars) (3,497 forks)batch import
buggood first issuehelp welcomelanguage

Description

Describe the issue

Escaped double quotations in string at attributes are not treated as a escaped character but a normal quotation.

Which language seems to have the issue?

Rust

Sample Code to Reproduce

#[derive(ThisError)]
enum MyError {
  #[error("\" appears in a string")]
  UnexpectedDoubleQuote
}

fn main() {}

sample at jsfiddle

image

Expected behavior

The escaped double quotation \" shouldn't be treated as a normal double quotation.

Contributor guide

Tech stack
rustjavascript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with highlight.js grammar structureUnderstanding of Rust string escaping rules
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is in the Rust language grammar file, likely `src/languages/rust.js`. The grammar needs to handle escaped double quotes in attribute strings. The fix involves updating the pattern for strings in attributes to recognize `\"` as an escaped quote. See the existing string handling in the grammar for reference. Check the issue comments for any additional context or partial solutions.