highlightjs/highlight.js

(Haskell) GADT syntax highlighted incorrectly

Open

#3,753 opened on Apr 11, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (22,960 stars) (3,497 forks)batch import
buggood first issuehelp welcomelanguage

Description

Describe the issue

The where keyword in the Haskell GADT syntax is not highlighted correctly

Which language seems to have the issue?

haskell

Are you using highlight or highlightAuto?

highlightElement

Sample Code to Reproduce

https://jsfiddle.net/8j5zb4ny/1/

Expected behavior

The where keyword at the end of the first line should get a different highlighting to show that it is not a type variable

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Haskell GADT syntaxhighlight.js grammar structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the Haskell grammar definition in src/languages/haskell.js. The issue is about the 'where' keyword in GADT syntax. Check the existing rules for keyword highlighting and see if there's a pattern for GADT that might be missing. Also review any comments on the issue for hints. Test with the provided sample.