highlightjs/highlight.js

(Crystal) formats integer divison incorrectly

Open

#3,730 opened on Mar 3, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (3,497 forks)batch import
buggood first issuehelp welcomelanguage

Repository metrics

Stars
 (22,960 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the issue Using // in crystal will make the highlighter mark the rest of the file. In crystal is // used for integer division. Code:

def something()
    something // 4
end

image

Which language seems to have the issue? Crystal

Are you using highlight or highlightAuto? highlight

Sample Code to Reproduce

def something()
    something // 4
end

image

Expected behavior The expected behavior is to not mark the rest of the code with the color green.

Additional context Nope

Contributor guide

Research direction
Inspect the Crystal language grammar in highlight.js to find where `//` is incorrectly parsed as a comment start. Trace the regex or mode that causes the rest of the file to be highlighted as comments.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptregex
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70