Support `Collection` types

Open Beginner friendly
#486 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
testing-qa, tooling

Research direction

Start in util.py by reading the existing List_ handling in type_contains_serialized_data, item_type, and is_var_sized_list. Run the binary compatibility tests with a Collection_Something type and compare the behavior with supported List_ types. Done means compatibility tests can be generated without the reported NoneType error.

Written by the indexing model from the issue text.

Description

List_ types are explicitly supported in util.py, where:

  • type_contains_serialized_data function returns whether the extracted type contains serialized data
  • item_type function returns a transformed version of the extracted type
  • is_var_sized_list function returns if it it's a list and not in FixSizedListTypes

Collection has no such support, and when a Collection_Something type is used, the following is logged:
Binary compatibility tests cannot be generated. Error: 'NoneType' object is not callable

Dominant language
Jinja
Stars
16
Forks
79
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from hazelcast/hazelcast-client-protocol

All issues in hazelcast/hazelcast-client-protocol

Similar issues

More Testing & QA issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.